From 593fcaa5ac72c577ff2b2a2f03ed071cb1b0f615 Mon Sep 17 00:00:00 2001
From: Ardis Lu <ardisglu@gmail.com>
Date: Fri, 12 Apr 2024 23:10:17 -0700
Subject: [PATCH] Refactor to simplify element references

---
 index.html | 43 ++++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/index.html b/index.html
index 6e0be4a..7a33a2c 100644
--- a/index.html
+++ b/index.html
@@ -158,39 +158,40 @@
     import { keccak256 } from '/keccak256.js';
     const interfaces = await fetch('/interfaces.json').then(r => r.json());
 
-    let lastSelection = 'Custom';
+    const form = document.querySelector('form');
+    const select = document.querySelector('select');
+    const textarea = document.querySelector('textarea');
+    const output = document.querySelector('output');
+
     let customFunctions = '';
-    document.querySelector('select').addEventListener('change', e => {
+    select.addEventListener('change', e => {
       const selection = e.target.value;
-      const textarea = document.querySelector('textarea');
-      const output = document.querySelector('output');
 
-      if (lastSelection === 'Custom') {
-        customFunctions = textarea.value;
-        textarea.readOnly = true;
-      }
-
-      lastSelection = selection;
       if (selection === 'Custom') {
         textarea.value = customFunctions;
         textarea.readOnly = false;
-        document.querySelector('form').requestSubmit();
-      }
-      else if (typeof interfaces[selection] === 'string') {
-        textarea.value = 'No functions: the interface ID for this ERC is hardcoded.';
-        output.textContent = interfaces[selection];
+        form.requestSubmit();
       }
       else {
-        textarea.value = interfaces[selection].join('\n');
-        document.querySelector('form').requestSubmit();
+        customFunctions = textarea.value;
+        textarea.readOnly = true;
+
+        if (typeof interfaces[selection] === 'string') {
+          textarea.value = 'No functions: the interface ID for this ERC is hardcoded.';
+          output.textContent = interfaces[selection];
+        }
+        else {
+          textarea.value = interfaces[selection].join('\n');
+          form.requestSubmit();
+        }
       }
     });
 
-    document.querySelector('form').addEventListener('submit', e => {
+    form.addEventListener('submit', e => {
       e.preventDefault();
-      const functions = new FormData(e.target).get('functions');
+
       const hashes = [];
-      for (let line of functions.split('\n')) {
+      for (let line of textarea.value.split('\n')) {
         // Ignore comment lines
         line = line.trim();
         if (line.substring(0, 2) === '//') {
@@ -251,7 +252,7 @@
       }
 
       const xorHash = `0x${[...xor].map(b => b.toString(16).padStart(2, '0')).join('')}`;
-      e.target.elements['output'].textContent = xorHash;
+      output.textContent = xorHash;
     });
   </script>
 </body>
-- 
2.47.3