From: Ardis Lu <ardisglu@gmail.com>
Date: Fri, 24 Dec 2021 07:41:04 +0000 (-0800)
Subject: Make input strings mandatory
X-Git-Url: https://git.ardis.lu/?a=commitdiff_plain;h=914a140e736d397217cd6ecb3835166a6cd97119;p=ArdisUtilities

Make input strings mandatory

It doesn't make sense to default to null or empty string, it should explicitly ask for input.
---

diff --git a/ArdisUtilities/ArdisUtilities.psm1 b/ArdisUtilities/ArdisUtilities.psm1
index 40393ef..34f3d9c 100644
--- a/ArdisUtilities/ArdisUtilities.psm1
+++ b/ArdisUtilities/ArdisUtilities.psm1
@@ -120,7 +120,7 @@ function ConvertTo-Base64String {
   [OutputType([String])]
   [CmdletBinding()]
   param(
-    [Parameter(ValueFromPipeline)]
+    [Parameter(Mandatory, ValueFromPipeline)]
     [String]$InputString
   )
 
@@ -168,8 +168,8 @@ function Get-StringHash {
   [OutputType('Microsoft.PowerShell.Commands.FileHashInfo')]
   [CmdletBinding()]
   param(
-    [Parameter(ValueFromPipeline)]
-    [String]$InputString = '',
+    [Parameter(Mandatory, ValueFromPipeline)]
+    [String]$InputString,
 
     [ValidateSet('SHA1', 'SHA256', 'SHA384', 'SHA512', 'MD5')]
     [String]$Algorithm = 'SHA1'